feat: add HttpxFetcher implementation (#2073) - #2983
Closed
ChickenisLegit wants to merge 2 commits into
Closed
Conversation
Signed-off-by: ChickenisLegit <ChickenisLegit@users.noreply.github.com>
…Docs Signed-off-by: ChickenisLegit <ChickenisLegit@users.noreply.github.com>
ChickenisLegit
force-pushed
the
feature/issue-2073-httpx-fetcher
branch
from
August 9, 2026 08:31
9d9b67f to
d4fa41e
Compare
Member
|
This PR looks good and fairly compact to me but my main worry is keeping this project sustainable with fewer maintainers and I would like to not add code if possible. In this case FetcherInterface is public so implementing a fetcher outside of the project is perfectly possible. So I'm not 100% against adding this into python-tuf but unless there's clear demand from users I'm leaning towards not doing so just to keep the code as minimal as possible. |
Member
Sorry for not doing this before you spent time on the PR but I did decide to close the issue now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional \HttpxFetcher\ implementation of \FetcherInterface\ that uses \httpx, providing HTTP/2 support. Resolves #2073.