Fix release workflow - #29
Merged
Merged
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
delthas
approved these changes
Aug 20, 2026
delthas
left a comment
Contributor
There was a problem hiding this comment.
Should we clear this .gitignore at build time, instead of CI pack time? Since we have build/ gitignored anyway.
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-18
branch
from
August 20, 2026 15:16
aaabe94 to
f23c44f
Compare
francoisferrand
approved these changes
Aug 20, 2026
Contributor
Author
|
/approve |
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue CLDSRVCLT-18. Goodbye sylvainsenechal. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRVCLT-18
Release was working until 1.0.9
1.0.10 bring a lot of changes around the .yaml release ci files, including a "npm pack" that takes the .gitignores into considerations. Problem is smithy generated code contains gitignores files => Release shipped without the code.
Didn't spot this on 1.0.10 release as cloudserver/backbeat stayed on 1.0.9