CLDSRV-978: Stop installing tcpdump in the kmip cluster job - #6258
CLDSRV-978: Stop installing tcpdump in the kmip cluster job#6258tcarmet wants to merge 1 commit into
Conversation
Hello tcarmet,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/9.3 #6258 +/- ##
================================================
Coverage 85.17% 85.17%
================================================
Files 206 206
Lines 13424 13424
================================================
Hits 11434 11434
Misses 1990 1990
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: approve, create_integration_branches |
| uses: ./.github/actions/setup-ci | ||
| - name: Install tcpdump to analyze traffic on kmip cluster interfaces | ||
| run: sudo apt-get update && sudo apt-get install -y tcpdump | ||
| run: sudo apt-get install -y tcpdump |
There was a problem hiding this comment.
This might not fix the issue with apt. It looks like the azure mirror used for ubuntu-latest is flaky and the issue can arise for any request (update or install of a package). (Frazzled-Productions/poke-memory#644).
Because the connection to the server stays open, apt doesn't timeout and hangs for hours.
Maybe we should add a timeout on those steps:
timeout-minutes: 5 # Forces GitHub to kill the step if it hangsOr use an action to timeout + retry: https://github.com/nick-fields/retry.
Or use linux timeout with a custom retry loop in shell
There was a problem hiding this comment.
I mean, it did fix the issue, but that's because tcpdump is already installed on those runners. So I was considering removing this package install.
But yes the issue remains cause those repos are down, but less we depend on it less are the chances something impact us.
I kept it here cause wanted to be safe in case a runner OS upgrade would remove tcpdump but what do you think? Should we remove it or do we tweak the step with a timeout and all?
There was a problem hiding this comment.
Well if it's already present you can remove by commenting the line with a description saying it's already present.
So if we change the runner or the image loses it, we can bring it back quickly
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
The step could hang when the apt mirrors are unresponsive. tcpdump already ships with the runner image, so the install is commented out rather than deleted, to make it easy to restore if a runner or image change ever drops the package.
2d49559 to
c39522f
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the The following options are set: create_integration_branches |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the The following options are set: create_integration_branches |
The KMIP cluster functional test job was hanging for hours on installing tcpdump, because of an unreliable Azure-hosted Ubuntu mirror. tcpdump already ships with the runner image, so the install was never needed - dropping it removes our exposure to that mirror.
The step is commented out rather than deleted, so it can be restored quickly if a future runner or image change drops the package.