Skip to content

CLDSRV-978: Stop installing tcpdump in the kmip cluster job - #6258

Open
tcarmet wants to merge 1 commit into
development/9.3from
bugfix/CLDSRV-978-tcpdump-install-no-apt-update
Open

CLDSRV-978: Stop installing tcpdump in the kmip cluster job#6258
tcarmet wants to merge 1 commit into
development/9.3from
bugfix/CLDSRV-978-tcpdump-install-no-apt-update

Conversation

@tcarmet

@tcarmet tcarmet commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The KMIP cluster functional test job was hanging for hours on installing tcpdump, because of an unreliable Azure-hosted Ubuntu mirror. tcpdump already ships with the runner image, so the install was never needed - dropping it removes our exposure to that mirror.

The step is commented out rather than deleted, so it can be restored quickly if a future runner or image change drops the package.

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-978 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.17

  • 9.4.2

Please check the Fix Version/s of CLDSRV-978, or the target
branch of this pull request.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.17%. Comparing base (24fb6b3) to head (c39522f).
⚠️ Report is 12 commits behind head on development/9.3.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           development/9.3    #6258   +/-   ##
================================================
  Coverage            85.17%   85.17%           
================================================
  Files                  206      206           
  Lines                13424    13424           
================================================
  Hits                 11434    11434           
  Misses                1990     1990           
Flag Coverage Δ
file-ft-tests 68.33% <ø> (-0.07%) ⬇️
file-ft-tests-null-compat 68.84% <ø> (-0.06%) ⬇️
kmip-ft-tests 28.36% <ø> (ø)
mongo-v0-ft-tests 69.58% <ø> (+0.02%) ⬆️
mongo-v1-ft-tests 69.60% <ø> (ø)
multiple-backend 36.83% <ø> (ø)
s3c-ft-tests-v0 64.07% <ø> (ø)
s3c-ft-tests-v0-null-compat 64.13% <ø> (ø)
s3c-ft-tests-v1 64.05% <ø> (ø)
sur-tests 35.98% <ø> (ø)
sur-tests-inflights 37.81% <ø> (-0.03%) ⬇️
unit 71.08% <ø> (ø)
utapi-v2-tests 34.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@tcarmet
tcarmet requested a review from a team August 19, 2026 22:07
@tcarmet

tcarmet commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@tcarmet
tcarmet requested a review from a team August 19, 2026 22:35
@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: approve, create_integration_branches

Comment thread .github/workflows/tests.yaml Outdated
uses: ./.github/actions/setup-ci
- name: Install tcpdump to analyze traffic on kmip cluster interfaces
run: sudo apt-get update && sudo apt-get install -y tcpdump
run: sudo apt-get install -y tcpdump

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not fix the issue with apt. It looks like the azure mirror used for ubuntu-latest is flaky and the issue can arise for any request (update or install of a package). (Frazzled-Productions/poke-memory#644).

Because the connection to the server stays open, apt doesn't timeout and hangs for hours.
Maybe we should add a timeout on those steps:

timeout-minutes: 5  # Forces GitHub to kill the step if it hangs

Or use an action to timeout + retry: https://github.com/nick-fields/retry.
Or use linux timeout with a custom retry loop in shell

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it did fix the issue, but that's because tcpdump is already installed on those runners. So I was considering removing this package install.

But yes the issue remains cause those repos are down, but less we depend on it less are the chances something impact us.

I kept it here cause wanted to be safe in case a runner OS upgrade would remove tcpdump but what do you think? Should we remove it or do we tweak the step with a timeout and all?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if it's already present you can remove by commenting the line with a description saying it's already present.

So if we change the runner or the image loses it, we can bring it back quickly

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, done

@bert-e

bert-e commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

The step could hang when the apt mirrors are unresponsive.

tcpdump already ships with the runner image, so the install is commented
out rather than deleted, to make it easy to restore if a runner or image
change ever drops the package.
@tcarmet
tcarmet force-pushed the bugfix/CLDSRV-978-tcpdump-install-no-apt-update branch from 2d49559 to c39522f Compare August 20, 2026 17:24
@scality scality deleted a comment from bert-e Aug 20, 2026
@tcarmet tcarmet changed the title CLDSRV-978: Install tcpdump without refreshing the apt index CLDSRV-978: Stop installing tcpdump in the kmip cluster job Aug 20, 2026
@bert-e

bert-e commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-978 contains:

  • 9.3.18

  • 9.4.2

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.19

  • 9.4.2

Please check the Fix Version/s of CLDSRV-978, or the target
branch of this pull request.

The following options are set: create_integration_branches

@bert-e

bert-e commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-978 contains:

  • 9.3.18

  • 9.4.2

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.20

  • 9.4.2

Please check the Fix Version/s of CLDSRV-978, or the target
branch of this pull request.

The following options are set: create_integration_branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants