CLDSRV-976: bump arsenal to 8.4.24 - #6256
Conversation
Hello tcarmet,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.3 #6256 +/- ##
===================================================
+ Coverage 85.18% 85.20% +0.02%
===================================================
Files 206 206
Lines 13434 13434
===================================================
+ Hits 11444 11447 +3
+ Misses 1990 1987 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5bb2dd3 to
eb1397a
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/9.4/bugfix/CLDSRV-976-bump-arsenal origin/development/9.4
git merge origin/bugfix/CLDSRV-976-bump-arsenal
# <intense conflict resolution>
git commit
git push -u origin w/9.4/bugfix/CLDSRV-976-bump-arsenalThe following options are set: create_integration_branches |
|
/status |
Status
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
Conflict with a changeset in the queueThe changeset in this pull request conflicts with another changeset This changeset has not been added to the queue. The following options are set: approve, create_integration_branches |
Arsenal 8.4.24 pulls in sproxydclient 8.2.2, which treats any 2xx response from sproxyd as a success instead of whitelisting 200 and 206. sproxyd answers DELETE and POST .batch_delete with 204 (no content), which the previous whitelist turned into an error, and DataWrapper then retried three times before surfacing an InternalError that reached the S3 client as a 500. Also bumps the project version to 9.3.18. Issue: CLDSRV-976
eb1397a to
ed1cce7
Compare
History mismatchMerge commit #eb1397ab3fa8f22cdaab5e432d01f2938de25e01 on the integration branch It is likely due to a rebase of the branch Please use the The following options are set: approve, create_integration_branches |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue CLDSRV-976. Goodbye tcarmet. The following options are set: approve, create_integration_branches |
|
/status |
sproxyd now answers DELETE and batch-delete requests with 204 No Content, and the sproxyd client carried by the previous Arsenal only accepted 200 and 206 as success. Deletes were therefore retried and eventually surfaced to S3 clients as internal errors. This picks up the Arsenal version carrying the fixed client so deletes succeed again.