Skip to content

fix: use backend node id for file inputs - #611

Merged
route merged 1 commit into
rubycdp:mainfrom
oiahoon:fix/file-input-backend-node
Aug 17, 2026
Merged

fix: use backend node id for file inputs#611
route merged 1 commit into
rubycdp:mainfrom
oiahoon:fix/file-input-backend-node

Conversation

@oiahoon

@oiahoon oiahoon commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • identify file inputs with their stable backendNodeId when calling DOM.setFileInputFiles
  • cover both the exact CDP command and a real Chrome file selection

Fixes #568

Verification

  • bundle exec rspec spec/node_spec.rb --example '#select_file' (2 examples)
  • bundle exec rake test (556 examples; the two local Chrome/path failures reproduce on unchanged main)
  • bundle exec rubocop --parallel (99 files)
  • bundle exec rake build
  • git diff --check

@route

route commented Aug 17, 2026

Copy link
Copy Markdown
Member

Thanks! I'll merge and remove unit test, it's a spec for real behavior not unit tests.

@route
route merged commit 38d1356 into rubycdp:main Aug 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOM.setFileInputFiles crashes renderer when using nodeId

2 participants