Bump Rust toolchain to 1.97.1 - #52
Open
perryqh wants to merge 2 commits into
Open
Conversation
Rust 1.97's clippy flags `&x` passed to format-like macros where the borrow is redundant, since Display and Debug forward transparently through references. Drop the borrow in the 8 affected call sites. Formatted output is byte-identical; no logic or error paths change. Landed ahead of the toolchain bump so each commit passes clippy on its own (verified clean under both 1.90 and 1.97). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Moves off 1.92.0 to current stable. No CI workflow pins a Rust version, so all jobs pick this up from rust-toolchain.toml automatically. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
perryqh
marked this pull request as ready for review
August 19, 2026 18:41
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-toolchain.tomlautomatically. The release workflow is cargo-dist-generated and installs via rustup, so it inherits it too.Why there are source changes
&passed to format-like macros, which 1.92's did not. Under CI'sRUSTFLAGS=-Dwarningsthese 9 warnings fail the Lints job, so the bump can't land without fixing them.format!("{}", &x)becomesformat!("{}", x).DisplayandDebugforward transparently through references, so formatted output is byte-identical and no behavior changes.Reviewing this
git bisectnever lands on a red commit.Contributor impact
rust-toolchain.toml.rust-version/MSRV is declared inCargo.toml, so no downstream compatibility constraint is affected.Heads-up: unrelated flaky test
While running the suite locally,
test_respect_gitignore_can_be_disabledfailed once under full concurrent load, then passed in isolation. This looks like a pre-existing test-isolation bug rather than something introduced here:test_respects_global_gitignoremutates the developer's real global git config (git config --global core.excludesFile) and is marked#[serial].serial_test's#[serial]only serializes against other#[serial]tests, not against unmarked parallel ones, sotest_respect_gitignore_can_be_disabledcan run whileexcludesFileis mid-set/unset and pick up a bogus ignore path.If CI goes red on that test, this is the likely cause. Worth fixing separately.
Related: a failed local run can leave
tests/fixtures/app_with_unnecessary_dependencies/packs/foo/package.ymlmodified, sincetest_auto_correct_unnecessary_dependenciesrewrites it and skips cleanup when the suite aborts.Follow-ups noted, deliberately not included
parse_utils.rs:149-152isif name.is_some() { name.unwrap_or_else(|| panic!(...)) }. The panic is unreachable given the guard and wants to beif let Some(..) = name. There is also a stale commented-out copy just above it that still contains the old&node, so it will drift further out of sync.ci.ymlusesactions/checkout@v2(deprecated Node runtime) andaudit.ymluses the archivedactions-rs/audit-check@v1.🤖 Generated with Claude Code