Deprecate the experimental EventsExecutor (backport #3192) - #3206
Deprecate the experimental EventsExecutor (backport #3192)#3206mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Skyler Medeiros <skye@polymathrobotics.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 5272750) # Conflicts: # rclcpp/test/rclcpp/executors/test_events_executor.cpp
|
Cherry-pick of 5272750 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Tick the box to add this pull request to the merge queue (same as
|
|
I don't think we allow this by the rules. Might be an exception as it is experimental ? |
fujitatomoya
left a comment
There was a problem hiding this comment.
what difference does it make if we add this deprecation?
i mean the enforcement will be on turtle-N after M (current rolling that deprecates EventsExecutor), why do we want to this deprecation warning M and L?
|
Yeah, I think we were trying to pull the deprecation cycle forward a release. It would be nice to not have to carry the experimental executor into M or N, since the non-experimental version already exists? I suppose the alternative would be to deprecate in M, remove completely in N, but I imagine that the experimental version will be effectively unmaintained from this point forward. |
|
This one has always been in the |
Description
This PR adds a compile-time deprecation warning when using the experimental EventsExecutor, warning to switch to the new Callback Group Events Executor in single-threaded mode instead.
Tests which exercise the EventsExecutor have deprecation warnings disabled while it is still in the source tree.
Also replaces one usage of the old executor with the new one in
rclcpp_action/test_server.cpp.Fixes # (issue)
Is this user-facing behavior change?
Users will now get a compiler warning when using the experimental EventsExecutor in their application code
Did you use Generative AI?
Claude Opus 4.8 was used to identify spots in the codebase where the deprecation warning suppression should be introduced.
Additional Information
This ought to be backported to at least Lyrical
This is an automatic backport of pull request #3192 done by Mergify.