Skip to content

fix(iOS): reuse prefetched images #57971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CHANDRAMOHANnegi wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

fix(iOS): reuse prefetched images #57971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/react-native/Libraries/Image/RCTImageLoader.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,14 @@ - (RCTImageURLLoaderRequest *)_loadImageOrDataWithURLRequest:(NSURLRequest *)req
size:size
scale:scale
resizeMode:resizeMode];
if (!image) {
// Prefetched images are cached at their original size. Reuse that
// entry for subsequent requests, which may specify a concrete size.
image = [[strongSelf imageCache] imageForUrl:request.URL.absoluteString
size:CGSizeZero
scale:1
resizeMode:RCTResizeModeStretch];
}
}

if (image) {
Expand Down Expand Up @@ -1133,6 +1141,11 @@ - (NSDictionary *)getImageCacheStatus:(NSArray *)requests
} else {
results[urlRequest.URL.absoluteString] = @"disk/memory";
}
} else if ([[self imageCache] imageForUrl:urlRequest.URL.absoluteString
size:CGSizeZero
scale:1
resizeMode:RCTResizeModeStretch]) {
results[urlRequest.URL.absoluteString] = @"memory";
}
}
}
Expand Down