fix: export feature flags for virtualized lists - #57969
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Fixes #57933.
PR #57484 removed the broad
./src/*export from thereact-nativepackage. However, the published@react-native/virtualized-listspackage still importsReactNativeFeatureFlagsthrough an unexported subpath. This causes Metro to emit a package-exports warning when applications render aFlatList.This change exposes only the exact feature-flags subpath required by
VirtualizedList, without restoring the broad./src/*export. It also adds a regression test verifying that the import resolves through the package exports map.Changelog:
[General] [Fixed] - Fix Metro package-exports warning when using VirtualizedList
Test Plan:
yarn test package-exports-test --runInBandyarn test VirtualizeUtils-test --runInBandyarn lint packages/virtualized-lists/Lists/__tests__/package-exports-test.jsgit diff --check