Handle zero-area layouts in VirtualizedList viewability (#57964) - #57964
Open
cipolleschi wants to merge 1 commit into
Open
Handle zero-area layouts in VirtualizedList viewability (#57964)#57964cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116026116. |
Summary: VirtualizedList treated horizontal lists with zero cross-axis size as visible because viewability only consumed the main-axis visible length. Track zero-area layouts, invalidate pending viewability updates, and report a zero visible length while collapsed. Keep RNTester screenshot checks deterministic by waiting for the configured `minimumViewTime` in the off-screen example and excluding variable callback content from the stable layout screenshot. Changelog: [General][Fixed] - Prevent zero-area lists from reporting items as viewable Differential Revision: D116026116
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D116026116
branch
from
August 14, 2026 15:39
87dd004 to
c299a69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
VirtualizedList treated horizontal lists with zero cross-axis size as visible because viewability only consumed the main-axis visible length. Track zero-area layouts, invalidate pending viewability updates, and report a zero visible length while collapsed.
Keep RNTester screenshot checks deterministic by waiting for the configured
minimumViewTimein the off-screen example and excluding variable callback content from the stable layout screenshot.Changelog:
[General][Fixed] - Prevent zero-area lists from reporting items as viewable
Differential Revision: D116026116