supports MatchOr, MatchSequence, MatchStar, MatchSingleton - #819
Merged
Conversation
jheld
force-pushed
the
match-or-sequence-star
branch
2 times, most recently
from
June 30, 2025 03:28
ad029d5 to
d60d56a
Compare
jheld
changed the title
lieryan
force-pushed
the
match-or-sequence-star
branch
from
August 20, 2026 11:46
d60d56a to
d7c0309
Compare
Member
|
Thanks for contributing this PR, @jheld. I've merged with a few additional fixes. @allcontributors please add @jheld for code contribution |
Contributor
|
I've put up a pull request to add @jheld! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes maybe all of #623
I was initially encountering an issue when trying to implement support for
MatchSingleton, but I realized that the singleton wasn't actually aName/NameConstant, but rather the string representation, at least in the test, so that helped me push through to support it as well.Checklist (delete if not relevant):