Use a comma as the fr_FR decimal separator - #378
Open
ckarnell wants to merge 1 commit into
Open
Conversation
fr_FR was the only locale in the table pairing a group separator with a dot decimal mark. French uses the comma, so intcomma and intword printed 1 234 567.89 instead of 1 234 567,89. naturalsize is unchanged because filesize.py does not read the separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fr_FRis the only entry in_DECIMAL_SEPARATORwith a dot. Every other locale there pairs a group separator with a comma, includinghu_HUandlv, which group with a space exactly like French does.You already worked this out in #357: the dot came from #248, and merwok said French needs the comma. That PR was closed by its author before it landed. So the value is still there.
One line of data. Plus the 26 fr_FR expectations that encoded the old output.
naturalsizeis deliberately untouched, and it is the one loose end.filesize.pynever reads the separator, so it still prints42.0 Kowhileintcommanow prints a comma. #357 tried to fix both together and picked up a 10% performance report on the bundle, so this leaves that half alone. Happy to send it separately if you want it, and it's a fair reason to hold this one.Tests are 789 passing before and after, same set. Reverting just the
i18n.pyline fails exactly the 26 updated expectations and nothing else, so the tests are pinned to the change, not to the diff.