Create release workflow - #4252
Conversation
…elease workflow, every Tuesday NY 3:30pm
|
cc: @doradocodes @raclim |
| - name: Delete temporary release branch | ||
| run: git push origin --delete "release-${{ inputs.newversion }}" |
There was a problem hiding this comment.
Wondering if we should really delete after merging, in case we need the branch again later? @raclim what do you think?
There was a problem hiding this comment.
Do you think we should push the branch to retain a history of these?
If so, would it be useful to update this to "release-${{ inputs.newversion }}-auto" (or similar suffix) to track when we're merging releases from the workflow vs. manual?
| 1. `version` can be `major`, `minor`, `patch`, etc. (see [npm-version](https://docs.npmjs.com/cli/version) for valid values. | ||
| 4. Wait for the workflow to run the `verify` job. | ||
| 1. This tests the checkout code from `develop`. | ||
| 2. If tests fail, the workflow will stop & record its result as a failure. Devs should fix any test failures, then attempt the [Create a release](../.github/workflows/release.yml) workflow again. |
There was a problem hiding this comment.
So if the tests fail, will the version get bumped twice?
There was a problem hiding this comment.
No the release.yaml > verify job doesn't include steps for bumping, those are in the release.yaml > release job
The input for version is just captured and used later on the release.yaml > release job (if release.yaml > verify passes)
|
Thanks for working on this so quickly @clairep94 ! |
Issue:
deployto run after a Github release occurs (currently happens on merges to thereleasebranch)release-reminder.ymlwhich runs Tuesday 15:30 UTC -- generates Issue with thecreate-releaseworkflow linkrelease.ymlwhich does two jobs:verify(CI testing) &release(creates the release draft, version, tags, etc).releasewaits on maintainer approval. Ifverifyfails, the workflow run fails.Demo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123