feat: frame visualization tool results with Shiny Chat - #274
Draft
cpsievert wants to merge 14 commits into
Draft
Conversation
cpsievert
commented
Aug 21, 2026
The previous test read R/querychat_viz.R from the package source tree, which does not exist when tests run under R CMD check. Exercise the visualize tool with mocked ggsql/session and assert on result@extra instead.
shinychat renamed the tool-result display field presentation -> open_style (with values minimal/framed); request the framed open style for visualization results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
Visualization tool results now use Shiny Chat's native framed presentation, so QueryChat no longer reaches into its condensed tool-display structure to create the surrounding frame.
Depends on posit-dev/shinychat#331.
What changes
presentation="framed"for visualization results in Python and R.Verification
uv run pytest pkg-py/tests/test_viz_footer.py -qRscript -e ...test-viz-tool.RA focused Playwright run exposed failures and then hung during teardown; this PR remains draft pending follow-up.