Remove deprecated mcp command and harden D1 import identifiers - #1360
Merged
Conversation
Use the hosted MCP server instead of the local pscale mcp command. Quote and validate identifiers written into D1 import pgloader scripts, and keep per-table load files inside the work directory. Co-authored-by: Cursor <cursoragent@cursor.com>
pgloader string literals cannot contain a single quote, so LIKE filters must not interpolate those names. Drop the leftover README note about the removed local mcp command. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed25b07. Configure here.
joshmgross
approved these changes
Aug 19, 2026
Names containing a double quote use pgloader's single-quoted form, which its CAST grammar accepts as an identifier. Also cover rejection of a column name that cannot be quoted. Co-authored-by: Cursor <cursoragent@cursor.com>
The test name already says what it covers. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated local
pscale mcpcommand. MCP clients should use the hosted server at https://mcp.pscale.dev/mcp/planetscale.Also quotes and validates identifiers written into D1 import pgloader scripts, and keeps per-table load files inside the work directory.