improve marginal test json input - #1065
Merged
Merged
Conversation
ahl
commented
Aug 20, 2026
| #[derive(:: serde :: Deserialize, :: serde :: Serialize, Clone, Debug)] | ||
| #[serde(transparent)] | ||
| pub struct ArraySansItems(pub Vec<::serde_json::Value>); | ||
| pub struct ArraySansItems(pub ::std::vec::Vec<::serde_json::Value>); |
Collaborator
Author
There was a problem hiding this comment.
note that this is (and was) wrong: we're not enforcing the minItems constraint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ "type": "array", "minItems": 1, "uniqueItems": true }It's kind of bullshit. It works today because we don't deal with Sets properly, but a HashSet<serde_json::Value> or BTreeSet<serde_json::Value> won't work because it's not
EqorOrd(because of the float in there). Let's change this to something we ostensibly know how to construct.