Tx eq settings - #349
Draft
cfzimmerman wants to merge 9 commits into
Draft
Conversation
Plumb this through such front ports can run ddm for multirack.
TODO: magnificent testing
cfzimmerman
commented
Aug 21, 2026
| //! ### Motivation | ||
| //! | ||
| //! - The previous API used `Option<i32>` for tap values. However, since | ||
| //! Tofino only supports updating all taps simultaneously, `None` values |
Author
There was a problem hiding this comment.
todo: clunky, reword top "Tofino updates all taps simultaneously"
cfzimmerman
commented
Aug 21, 2026
Comment on lines
+90
to
+91
| /// These only apply to ports without per-MPN settings or | ||
| /// an active user config. |
Author
There was a problem hiding this comment.
Todo clunky: "These apply in absence of ..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. I'll clean up this branch, add docs, and figure out validation over the coming few days. Creating this now as a place to put notes.
Motivating issue: #145
TODO see if this is also relevant: #135