Avoid sorting formik in place in scheduling tab - #1658
Open
Arnei wants to merge 1 commit into
Open
Conversation
There is a validation function that is mutating formik arrays accidentally by sorting it. This should not happen, so the solution is to make shallow copies of the arrays, which should have no effect on the validity check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a validation function that is mutating formik arrays accidentally by sorting it. This should not happen, so the solution is to make shallow copies of the arrays, which should have no effect on the validity check.
How to test this
For a scheduled event, check that the scheduling tab in the event details still works as expected.
AI Usage
Claude Sonnet was used to find and rectify this issue.