Annotate kills made from smoke in kills_log - #91
Merged
Conversation
Track Smoke of Deceit modifier windows per hero in a pre-scan keyed by event time, and add smoke: true to kills_log entries where the killer was smoked at the kill or up to 30 seconds earlier: the smoke pops on proximity when the gank starts and the kills land over the following fight. Validated against reference smoke labels on four pro matches (285/285 kills, half held out of the calibration), with the rest of the blob byte-identical.
howardchung
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
smoke: trueto kills_log entries where the killer was under Smoke of Deceit at the kill or up to 30 seconds earlier. Windows come from a pre-scan of the modifier add/remove events keyed by event time (same pattern as the reincarnation pre-scan). Closes odota/core#1477.The 30s linger isn't arbitrary: the smoke pops when the gank starts and the kills land over the following fight. Calibrated against Stratz's isSmoke label (their flagged kills fall 0-29s after the break) on 2 pro matches, validated on 2 held-out matches plus a fresh one this week: 332/332 kills agree across the 5, zero false positives. With the field stripped the blob is byte-identical to master, and a match with no smokes has zero footprint. Storage cost is a boolean on the handful of smoked kills per match (~9 in a pro game).
odota/web#3369 shows it on the site: a smoke icon on the kill entries in the match log.