fix(spec): correct console route spellings in JSDoc to /_console/… - #9155
Merged
Conversation
Three JSDoc sites in packages/spec/src/ui/{view,action}.zod.ts spelled
the console form routes without the /_console underscore, against the
measured mount (CONSOLE_PATH = '/_console' in packages/cli/src/utils/
console.ts). No route resolves at a bare /console prefix.
- view.zod.ts:2446 and :2449 (FormViewSchema.submitBehavior JSDoc,
including the 2026-08-10 #7245 ruling sentence — the ruling itself
pins the mode-aware submitBehavior default, not path spelling, so
only the incidental path text changed)
- action.zod.ts:500 (the type: 'form' action target doc)
Comment-only change: these are JSDoc blocks, not .describe() strings,
so accept/reject behaviour and the generated references pipeline are
both unaffected (verified: pnpm --filter @objectstack/spec
check:generated reports all 13 generated artifacts up to date, no
diff under content/docs/references/).
Fixes #9078
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 106 hand-written doc(s) reference the affected code — list omitted above 15 rows. Re-derive: ⛔ 7 release-owned page(s) also affected — read-only, see AGENTS.md Documentation Guardrails.
|
os-zhuang
marked this pull request as ready for review
August 16, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9078
What
Three JSDoc sites in
packages/spec/src/ui/{view,action}.zod.tsspelled the console form routes without the/_consoleunderscore, against the measured mount (CONSOLE_PATH = '/_console'inpackages/cli/src/utils/console.ts:43). No bare/consoleroute resolves.view.zod.ts:2446—`/console/f/:slug`→`/_console/f/:slug`(inside theFormViewSchema.submitBehaviordoc, including the2026-08-10 #7245ruling sentence — the ruling itself pins the mode-aware submitBehavior default, not path spelling, so only the incidental path text changed; the ruling's substance is byte-identical)view.zod.ts:2449—`/console/forms/:name`→`/_console/forms/:name`(same doc block)action.zod.ts:500—`/console/forms/:name`→`/_console/forms/:name`(thetype: 'form'action target doc)Sweep guard: grepped both files for any other bare
/console/spelling — none found beyond the three named sites.Why
These are JSDoc comments, not
.describe()strings, so this is a comment-only, byte-identical-behavior change — no schema/accept/reject-path is touched.Products follow source
Ran the regen pipeline per AGENTS.md:
pnpm --filter @objectstack/spec buildthenpnpm --filter @objectstack/spec check:generated. All 13 generated artifacts (includingcheck:docs→content/docs/references/**) report up to date — no diff produced. This confirms the issue's premise: these JSDoc blocks are not currently published to any reference page, so the regen step is a no-op here. Nothing to commit undercontent/docs/references/.Tests
At head
a3ddfeee7:pnpm --filter @objectstack/spec build— greenpnpm --filter @objectstack/spec check:generated— all 13 generated artifacts up to date (no-op, as expected for a comment-only change)pnpm --filter @objectstack/spec typecheck— green (tsc --noEmit,check:scripts-typecheck,check:test-typecheck)pnpm --filter @objectstack/spec test— 406 test files / 10807 tests passedpnpm check:cross-package-test-inputs— greenpnpm check:merge-driver— greenpnpm check:spec-parsed-alias— green (ADR-0122 alias convention: 1518 bare aliases, 837 pinned isomorphic, 681 paired)pnpm check:type-source-resolution— greenpnpm check:i18n— green (built@objectstack/clifirst per the gate's own prerequisite message; 9 packages, all bundles in sync, no undeclared authoring keys)pnpm check:nul-bytes— green (5998 tracked text files scanned)pnpm --filter @objectstack/lint run check:doc-formula-expressions— greenGate union derived from actual changed paths via
node scripts/pm/dispatch-gates.mjs packages/spec/src/ui/view.zod.ts packages/spec/src/ui/action.zod.ts— all 7 matched families run above; nothing further implicated by this diff.Changeset
.changeset/console-route-jsdoc-spelling.md—@objectstack/specpatch.Generated by Claude Code
Generated by Claude Code