docs(qa): reword the #2567 Phase 2 authz-conformance comment off a fixed route list - #9145
Draft
os-project-manager wants to merge 1 commit into
Draft
docs(qa): reword the #2567 Phase 2 authz-conformance comment off a fixed route list#9145os-project-manager wants to merge 1 commit into
os-project-manager wants to merge 1 commit into
Conversation
…te list (#9027) The `#2567 Phase 2` comment (and two sibling mentions of the same claim in this file) described discover()'s static enumeration as covering data/meta/graphql HTTP entry points only. PROBES has grown to 15 probes over 11 named source files across 7 route families (meta, actions, automation, packages, data, realtime, mcp) since that comment was written, and no `graphql` probe exists in the table today — the old wording was already inaccurate on that front too. Reworded generically (HTTP/transport entry points named in the curated PROBES table) rather than re-enumerating the current families, per the issue's own reasoning: an enumerated list is what drifted in the first place, so replacing one fixed list with another just re-creates the mechanism that caused this finding. discover() itself is unchanged and correctly enumerates all 15 surfaces; this is a prose-only fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y26DJEHSBhhAQ6wwfsHNza
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9027
What
packages/qa/dogfood/test/authz-conformance.test.tscarried a "#2567 Phase 2" comment describingdiscover()'s static enumeration as coveringdata/meta/graphqlHTTP entry points only. That was accurate when written but thePROBEStable has grown well past it. Reworded the description generically instead of naming a fixed route-segment list, per the issue's own reasoning: an enumerated list is what drifted in the first place, so swapping one fixed list for another (even an up-to-date one) re-creates the exact mechanism that produced this finding.discover()itself is unchanged and correct — this is a prose-only fix to three comments in one file.Re-derived numbers (per triage instruction — not copied from the card)
Re-derived on current
origin/main(after confirming #9026 landed as2ce1eb41b) with a small extraction script that parses everyfile:key out of thePROBESarray literal — verified the extraction actually reads real quoted paths (not a guessed regex silently returning zero matches):meta,actions,automation,packages,data,realtime,mcp.graphqlprobe exists in the table today — the old "data/meta/graphql" wording was already stale on that front too (searched:graphqlappears only in the comments being fixed here, never in aPROBESentry).This matches the card's own re-derivation (15/11), independently confirmed rather than copied.
Bounded in-place sweep
The issue names one specific comment block (quoted verbatim, unique "Phase 2" text at the top of the file). While fixing it I found the identical stale claim ("data/meta/graphql") repeated twice more in the same file — immediately above the
PROBEStable declaration, and inline inside thecheckLedgercall — both describing the same table using the same now-inaccurate vocabulary. Extended the fix to all three per the bounded in-place exemption: same defect class, mechanical (same generic-wording treatment already decided for the named comment, applied consistently), file held only by this claim, no new verification surface (comments only). Leaving two of three near-identical descriptions stale while fixing the third would have left contradictory claims meters apart in the same file.Tests
Union run at final commit
60fc93198:Gate selection:
check:test-source-alias/check:type-source-resolutionare the path-derived gates forpackages/qa;check:engine-double-contract,check:where-matcher,check:query-options-erasureare convention-triggered by editing a test file (node scripts/pm/dispatch-gates.mjs). Did not run the repo-widecheck:type-check-coverage/check:type-check-debtre-measure — the diff is comments only in an already-typechecked, already-tracked file (no new file, no new export, no code-path change), so the package's own cleantsc --noEmitstands in for it; flagging this choice rather than silently skipping it.Changeset
Test-file comment change, nothing published — no changeset. Applying the
skip-changesetlabel (this repo's real mechanism, per the maintainer note on #9133) as part of this PR, reading back the label set after the changeset-gate bot's first pass rather than declaring it done on the write alone.Generated by Claude Code