Skip to content

docs(qa): reword the #2567 Phase 2 authz-conformance comment off a fixed route list - #9145

Draft
os-project-manager wants to merge 1 commit into
mainfrom
claude/issue-9027-authz-probes-comment
Draft

docs(qa): reword the #2567 Phase 2 authz-conformance comment off a fixed route list#9145
os-project-manager wants to merge 1 commit into
mainfrom
claude/issue-9027-authz-probes-comment

Conversation

@os-project-manager

Copy link
Copy Markdown
Collaborator

Fixes #9027

What

packages/qa/dogfood/test/authz-conformance.test.ts carried a "#2567 Phase 2" comment describing discover()'s static enumeration as covering data/meta/graphql HTTP entry points only. That was accurate when written but the PROBES table has grown well past it. Reworded the description generically instead of naming a fixed route-segment list, per the issue's own reasoning: an enumerated list is what drifted in the first place, so swapping one fixed list for another (even an up-to-date one) re-creates the exact mechanism that produced this finding.

discover() itself is unchanged and correct — this is a prose-only fix to three comments in one file.

Re-derived numbers (per triage instruction — not copied from the card)

Re-derived on current origin/main (after confirming #9026 landed as 2ce1eb41b) with a small extraction script that parses every file: key out of the PROBES array literal — verified the extraction actually reads real quoted paths (not a guessed regex silently returning zero matches):

  • 15 probes over 11 named source files, spanning 7 route families: meta, actions, automation, packages, data, realtime, mcp.
  • No graphql probe exists in the table today — the old "data/meta/graphql" wording was already stale on that front too (searched: graphql appears only in the comments being fixed here, never in a PROBES entry).

This matches the card's own re-derivation (15/11), independently confirmed rather than copied.

Bounded in-place sweep

The issue names one specific comment block (quoted verbatim, unique "Phase 2" text at the top of the file). While fixing it I found the identical stale claim ("data/meta/graphql") repeated twice more in the same file — immediately above the PROBES table declaration, and inline inside the checkLedger call — both describing the same table using the same now-inaccurate vocabulary. Extended the fix to all three per the bounded in-place exemption: same defect class, mechanical (same generic-wording treatment already decided for the named comment, applied consistently), file held only by this claim, no new verification surface (comments only). Leaving two of three near-identical descriptions stale while fixing the third would have left contradictory claims meters apart in the same file.

Tests

Union run at final commit 60fc93198:

pnpm --filter "@objectstack/dogfood^..." build                         → 0 (dependency closure built)
pnpm --filter "@objectstack/dogfood" exec vitest run test/authz-conformance.test.ts --maxWorkers=2
  → Test Files  1 passed (1) / Tests  15 passed (15)
pnpm --filter "@objectstack/dogfood" typecheck                          → clean (tsc --noEmit)
pnpm check:test-source-alias                                            → OK
pnpm check:type-source-resolution                                       → OK
pnpm check:engine-double-contract                                       → OK — 311 pinned, 133 in DEBT ledger, 2 exempt (unchanged)
pnpm check:where-matcher                                                → holds, 247/247, none new
pnpm check:query-options-erasure                                        → holds, 67 unswept non-test sites, none new
node scripts/check-nul-bytes.mjs <changed file>                         → OK

Gate selection: check:test-source-alias / check:type-source-resolution are the path-derived gates for packages/qa; check:engine-double-contract, check:where-matcher, check:query-options-erasure are convention-triggered by editing a test file (node scripts/pm/dispatch-gates.mjs). Did not run the repo-wide check:type-check-coverage / check:type-check-debt re-measure — the diff is comments only in an already-typechecked, already-tracked file (no new file, no new export, no code-path change), so the package's own clean tsc --noEmit stands in for it; flagging this choice rather than silently skipping it.

Changeset

Test-file comment change, nothing published — no changeset. Applying the skip-changeset label (this repo's real mechanism, per the maintainer note on #9133) as part of this PR, reading back the label set after the changeset-gate bot's first pass rather than declaring it done on the write alone.


Generated by Claude Code

…te list (#9027)

The `#2567 Phase 2` comment (and two sibling mentions of the same claim in
this file) described discover()'s static enumeration as covering
data/meta/graphql HTTP entry points only. PROBES has grown to 15 probes over
11 named source files across 7 route families (meta, actions, automation,
packages, data, realtime, mcp) since that comment was written, and no
`graphql` probe exists in the table today — the old wording was already
inaccurate on that front too.

Reworded generically (HTTP/transport entry points named in the curated
PROBES table) rather than re-enumerating the current families, per the
issue's own reasoning: an enumerated list is what drifted in the first
place, so replacing one fixed list with another just re-creates the
mechanism that caused this finding. discover() itself is unchanged and
correctly enumerates all 15 surfaces; this is a prose-only fix.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y26DJEHSBhhAQ6wwfsHNza
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

No hand-written docs reference the 0 changed package(s). ✅

@github-actions github-actions Bot added the tests label Aug 16, 2026
@os-project-manager os-project-manager added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Aug 16, 2026 — with Claude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] authz-conformance.test.ts's "#2567 Phase 2" comment still describes discover() as data/meta/graphql only — PROBES has grown past that

2 participants