Skip to content

Fix AIO webhook worker command - #15401

Open
lntutor wants to merge 1 commit into
nextcloud:masterfrom
lntutor:docs/15399-aio-container-name-dco
Open

Fix AIO webhook worker command#15401
lntutor wants to merge 1 commit into
nextcloud:masterfrom
lntutor:docs/15399-aio-container-name-dco

Conversation

@lntutor

@lntutor lntutor commented Jul 31, 2026

Copy link
Copy Markdown

☑️ Resolves

🖼️ Screenshots

Not applicable; this corrects a command example without changing visual documentation.

✅ Checklist

  • I have built the documentation locally and reviewed the output
  • Screenshots are included for visual changes (not applicable)
  • I have not moved or renamed pages
  • I have run codespell and addressed any spelling issues

Validation: sphinx-lint, codespell, and the warning-as-error Administration Manual HTML build all pass.

Signed-off-by: Loi Nguyen <vanloi999@gmail.com>
@lntutor

lntutor commented Aug 1, 2026

Copy link
Copy Markdown
Author

Current head 1c27933602c85caff944745934355662143a0719 is mergeable, DCO is green on this head, and there are no unresolved review threads on the current PR state. This looks ready for maintainer review when convenient.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

.. code-block::

set -e; while true; do sudo docker exec -it nextcloud-aio-nextcloud docker exec -it nextcloud-aio-nextcloud sudo -E -u www-data php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done
set -e; while true; do sudo docker exec -it nextcloud-aio-mastercontainer docker exec -it nextcloud-aio-nextcloud sudo -E -u www-data php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set -e; while true; do sudo docker exec -it nextcloud-aio-mastercontainer docker exec -it nextcloud-aio-nextcloud sudo -E -u www-data php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done
set -e; while true; do sudo docker exec --user www-data nextcloud-aio-nextcloud php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why you suggest this but I think the change would be worthwhile to merge without your suggestion, too, correct?

I'm wondering why to call docker inside the mastercontainer in the first place. It's controlling the same docker daemon as from the host system, isn't it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it doesnt make sense. That why I added this suggestion

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you for the confirmation!

@pabzm

pabzm commented Aug 21, 2026

Copy link
Copy Markdown
Member

@lntutor Thank you for your contribution, and sorry that it took so long to review it!

Your change fixes the actual execution, but @szaimen's requested change remove a useless indirection, and even improves the change in our eyes. Could you apply the suggestion? Then we'd happily merge this! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small typo for AIO webhook polling script

4 participants