Bound OAuth response bodies in the client - #520
Open
koic wants to merge 1 commit into
Open
Conversation
koic
force-pushed
the
bound_oauth_response_bodies
branch
from
August 15, 2026 18:27
be96023 to
454c07e
Compare
## Motivation and Context `MCP::Client::HTTP` caps a single message from the server at 4 MiB, but the OAuth flow talks to authorization endpoints over its own Faraday connection, and that one had no cap. Discovery, dynamic client registration, and token responses were buffered in full and handed to `JSON.parse`, so a server that answered an OAuth request with an endless body grew the client's memory for as long as it kept sending. `Flow` and `IDJAGTokenExchange` each build their own connection, so both needed the bound. The new `BoundedBody` counts bytes in a Faraday `on_data` callback and refuses the response once it passes `MAX_RESPONSE_BYTES`, which matches the 4 MiB of `MCP::Client::HTTP::MAX_MESSAGE_BYTES` and `MCP::Client::Stdio::MAX_LINE_BYTES`. It hands back the status paired with the bounded body rather than the Faraday response, so no later caller can reach the unbounded `response.body`. Those bytes are counted after decompression. The default Net::HTTP adapter negotiates `Accept-Encoding` itself and reads the body through `Net::HTTPResponse#inflater`, so a small compressed body that expands past the cap is refused partway through the expansion. That holds only while the connection leaves `Accept-Encoding` alone, which is now recorded in a comment on both `default_http_client` definitions. An over-cap response is refused rather than truncated: a partial discovery or token document cannot be validated. Protected resource metadata is the one place where refusing is not fatal, since any PRM discovery failure already selects the legacy authorization path by design. ## How Has This Been Tested? New unit tests in `test/mcp/client/oauth/bounded_body_test.rb` cover the streaming path, the at-limit boundary, and the fallback for adapters that ignore `on_data`. One of them serves a gzip body over a real socket rather than through WebMock, which returns a stubbed body verbatim and never runs the inflater; it fails if the cap ever starts measuring compressed bytes. New tests in `test/mcp/client/oauth/flow_test.rb` and `test/mcp/client/oauth/id_jag_token_exchange_test.rb` drive each of the four request wrappers end to end with an over-cap body; all five fail without the cap in place. ## Breaking Changes An OAuth endpoint response larger than 4 MiB is now rejected instead of parsed.
koic
force-pushed
the
bound_oauth_response_bodies
branch
from
August 15, 2026 18:29
454c07e to
02db089
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
MCP::Client::HTTPcaps a single message from the server at 4 MiB, but the OAuth flow talks to authorization endpoints over its own Faraday connection, and that one had no cap. Discovery, dynamic client registration, and token responses were buffered in full and handed toJSON.parse, so a server that answered an OAuth request with an endless body grew the client's memory for as long as it kept sending.FlowandIDJAGTokenExchangeeach build their own connection, so both needed the bound. The newBoundedBodycounts bytes in a Faradayon_datacallback and refuses the response once it passesMAX_RESPONSE_BYTES, which matches the 4 MiB ofMCP::Client::HTTP::MAX_MESSAGE_BYTESandMCP::Client::Stdio::MAX_LINE_BYTES. It hands back the status paired with the bounded body rather than the Faraday response, so no later caller can reach the unboundedresponse.body.Those bytes are counted after decompression. The default Net::HTTP adapter negotiates
Accept-Encodingitself and reads the body throughNet::HTTPResponse#inflater, so a small compressed body that expands past the cap is refused partway through the expansion. That holds only while the connection leavesAccept-Encodingalone, which is now recorded in a comment on bothdefault_http_clientdefinitions.An over-cap response is refused rather than truncated: a partial discovery or token document cannot be validated. Protected resource metadata is the one place where refusing is not fatal, since any PRM discovery failure already selects the legacy authorization path by design.
How Has This Been Tested?
New unit tests in
test/mcp/client/oauth/bounded_body_test.rbcover the streaming path, the at-limit boundary, and the fallback for adapters that ignoreon_data. One of them serves a gzip body over a real socket rather than through WebMock, which returns a stubbed body verbatim and never runs the inflater; it fails if the cap ever starts measuring compressed bytes. New tests intest/mcp/client/oauth/flow_test.rbandtest/mcp/client/oauth/id_jag_token_exchange_test.rbdrive each of the four request wrappers end to end with an over-cap body; all five fail without the cap in place.Breaking Changes
An OAuth endpoint response larger than 4 MiB is now rejected instead of parsed.
Types of changes
Checklist