fix: validate resource URIs and cap subscriptions per session - #1095
Open
ez-lbz wants to merge 1 commit into
Open
fix: validate resource URIs and cap subscriptions per session#1095ez-lbz wants to merge 1 commit into
ez-lbz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec's server resources security guidance requires servers to validate all resource URIs. The read path validates URIs against the registered resources and resource templates, but resources/subscribe accepted any string URI into an unbounded map, so an authenticated client could grow memory without limit.
This change makes the subscribe handler resolve the URI through the same resource/template lookup as the read path and reject unknown URIs with the same Resource Not Found error (-32002). It also caps the number of resource subscriptions per session (1024); further subscribe requests are rejected with Invalid Params (-32602).
Tests cover subscribing to a registered URI (success), an unregistered URI (Resource Not Found), and exceeding the per-session cap (Invalid Params).