feat(wrapper-generator): generate remaining OData operation shapes - #3724
Open
Joywambui-maina wants to merge 2 commits into
Open
feat(wrapper-generator): generate remaining OData operation shapes#3724Joywambui-maina wants to merge 2 commits into
Joywambui-maina wants to merge 2 commits into
Conversation
- Emit media/content downloads (78 routes), completing the shape list in #3709 - Stamp each cmdlet with a [GraphRoute] attribute so the parity gate reads the operation's route from the compiled assembly rather than reconstructing it from generated C#, removing the cast and parameterized-function exclusions that left 1,669 cmdlets unverified - Order Count before the cast suffix on /$count routes (126 cmdlets) - Drop the unusable -OutFile parameter from content writes returning an entity - Collapse the three parallel OData segment tables into one - Refresh generator docs against measured figures 38/38 modules generate and build, 184/184 tests.
…s' into feat/wrapper-operation-shapes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request
/content,/logo,/favicon,attachmentsArchive), completing the shape list in WrapperGenerator: generate OData actions, functions, and remaining operation shapes #3709 — every shape it names now emits, compiles and imports[GraphRoute(method, path)]attribute so the parity gate reads the operation's route from the compiled assembly instead of reconstructing it from generated C#. Reconstruction is lossy for parameterized functions and wrong for namespace-qualified actions, so the gate had been excluding 1,669 cmdlets from comparison — it now excludes noneCountbefore the cast suffix on/$countroutes, matching the published SDK (Get-MgUserMemberOfCountAsGroup, not…AsGroupCount) — 126 cmdlets-OutFileparameter from content writes whose response is an entity rather than a stream; it was declared but never read on 56 cmdlets38/38 modules generate and build · 184/184 unit tests · 11,737 cmdlets
Note on diff size: ~76k of the insertions are the derived parity data (
parity-input-ledger.v1.0.csvand the threeparity-*.json), which are generated and pinned byParityDataDriftTests. The hand-written code and docs are roughly 2,000 lines.Depends on:
feat/bind-request-body-properties—powershell-v3doesn't yet haveDerivedCollisionResolutions.csor the collision data this builds on, so a branch based there wouldn't compile. Retarget once the parent merges.