Fix syntax error in AsyncDisposable example - #3629
Merged
Jake Bailey (jakebailey) merged 2 commits intoAug 18, 2026
Merged
Conversation
Jake Bailey (jakebailey)
previously approved these changes
Aug 18, 2026
Member
|
Yeah, I believe you're right on the second count, so I'd fix it |
There was a problem hiding this comment.
Pull request overview
Fixes the asynchronous disposal example so it compiles and correctly awaits transaction cleanup.
Changes:
- Replaces an invalid colon with a semicolon.
- Uses
await usingfor the async-disposable transaction.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Aug 18, 2026
Jake Bailey (jakebailey)
enabled auto-merge (squash)
August 18, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AsyncDisposable example in the variable declarations reference has a syntax error:
const db = this.db:uses a colon instead of a semicolon, so the example doesn't compile.Separately, I noticed the
transferfunction usesusing txon an async-disposable resource , should that beawait using txso the async disposal is actually awaited? Happy to include that fix too if you'd like !