Skip empty channel slots in searchChannelsByHash - #3249
Open
dl9sau wants to merge 1 commit into
Open
Conversation
An unconfigured slot has an all-zero secret, so it matches null-key group traffic (a sender with an unset PSK). The zero-key MAC validates against the empty slot and the foreign message is delivered as if it belonged to that channel — every node with a free slot is a null-key sink. Skip empty slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A misconfigured node on our network transmits group messages with an
unset PSK (channel 0 / key 0). This is genuinely received over the air,
not a local parser bug — the packet's MAC validates against the zero key.
searchChannelsByHash() includes empty/unconfigured slots in the hash
match. An empty slot's secret is all-zero, so it matches this null-key
traffic and the message is delivered as if it belonged to the first free
slot. Not shown as a normal message, but it triggered my (fork-local)
private-channel notification. Every node with a free channel slot is
affected.
Fix: skip empty slots in searchChannelsByHash.