You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The proof turned out to be not as simple as for the exp case, due to a subtle difference in the defining series for Rcos and cos:
the former is
1 - (x^2/2!) + (x^4/4!) ...
while the latter is
1 + 0 - (x^2/2!) + 0 + (x^4/4!) + 0 ...
That said, the proof script for RcosE seems a bit too long, and there could be a better proof strategy.
t6s
changed the title
Rcos e 20260817
add compatibility lemmas for Stdlib Rcos and RsinAug 16, 2026
The proof turned out to be not as simple as for the exp case, due to a subtle difference in the defining series for Rcos and cos: the former is 1 - (x^2/2!) + (x^4/4!) ... while the latter is 1 + 0 - (x^2/2!) + 0 + (x^4/4!) + 0 ...
The proof turned out to be not as simple as for the exp case, due to a subtle difference in the defining series for Rcos and cos: the former is 1 - (x^2/2!) + (x^4/4!) ... while the latter is 1 + 0 - (x^2/2!) + 0 + (x^4/4!) + 0 ...
By the way, this is not a useful comment anymore since the need has disappeared, but big_nat_dvdn should have gone to mathcomp_compat.v rather than unstable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Context:
https://rocq-prover.zulipchat.com/#narrow/channel/237666-math-comp-analysis/topic/relating.20trigo.2Ecos.20to.20Rtrigo_def.2Ecos.2C.20etc.2E
This PR adds compatibility lemmas for a few trigonometry functions defined in Stdlib Reals,
namely
RcosandRsin. A lemma for π is also added.Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers