Mandate TDD with observable-behavior e2e tests in agent guidance - #445
Merged
Conversation
skyrpex
added
semver: patch
docs: skip
Member
|
What do you think, @anisaoshafi? Looks good to merge, or close? |
anisaoshafi
marked this pull request as ready for review
August 18, 2026 09:46
anisaoshafi
approved these changes
Aug 18, 2026
anisaoshafi
left a comment
anisaoshafi
left a comment
Collaborator
There was a problem hiding this comment.
💯 Good idea to make this explicit - I did have to prompt several times during on my reviews to actually do this red -> green testing to make sure the implementation took the right effect.
Co-Authored-By: Claude <noreply@anthropic.com>
anisaoshafi
force-pushed
the
claude/tdd-workflow-agents-804d33
branch
from
August 18, 2026 09:49
2a70674 to
121b324
Compare
anisaoshafi
enabled auto-merge (squash)
August 18, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Agent sessions were writing implementations first and backfilling tests. We want the opposite: every feature or fix starts from a failing end-to-end test.
Solution
Extends the Testing section in CLAUDE.md (AGENTS.md symlinks to it) with three rules: TDD is mandatory (red → green → refactor — write the e2e test, confirm it fails for the expected reason, then implement); e2e tests assert only observable behavior (exit codes, output, files, requests received), asking the user when the observable behavior is unclear; and observable mocks of external systems (mock auth endpoint, fake
aws/azon PATH, fake browser opener) are encouraged as the product boundary — never mocks of lstk internals. Also adds a matching checklist line to the/review-prskill so the rule is enforced at review time.Docs
Nothing to document — agent/contributor guidance only, no user-facing behavior change.
Review
Self-merge candidate — guidance-only change, no code touched, content was specified directly in the session.
Co-Authored-By: Claude noreply@anthropic.com