Skip to content

feat: Populate OpenFeature flag metadata from the evaluation reason - #31

Merged
kinyoklion merged 1 commit into
mainfrom
devin/ruby-flag-metadata
Aug 21, 2026
Merged

feat: Populate OpenFeature flag metadata from the evaluation reason#31
kinyoklion merged 1 commit into
mainfrom
devin/ruby-flag-metadata

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Aug 19, 2026

Copy link
Copy Markdown
Member

Populates OpenFeature flag metadata with the LaunchDarkly specific parts of the evaluation result, so hooks (including the OpenTelemetry hook) can read them.

No screenshots or staging preview apply - this is a server-side library change with no UI.

Implementation details

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Describe the solution you've provided

ResolutionDetailsConverter#to_resolution_details now passes flag_metadata:

flag_metadata: flag_metadata(reason, is_default ? nil : variation_index)

Each entry is gated on the corresponding reason field being present rather than on the reason kind, so no key is written from a sentinel value. big_segments_status is a symbol in the Ruby SDK, so it is stringified to keep the metadata value types consistent with the other providers.

The README gains a "Flag Metadata" section documenting the keys.

Describe alternatives you've considered

Exposing the reason object itself as one metadata entry would be closer to the LaunchDarkly shape, but OpenFeature flag metadata values are scalars, so the flat keys are the only available shape.

Additional context

docker run --rm -v "$PWD":/app -w /app ruby:3.4 bash -c "bundle install && bundle exec rake"

61 examples, 0 failures; RuboCop clean. 7 new examples cover each key and the omissions.

@cursor review

Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion


Note

Overview
OpenFeature evaluations now include LaunchDarkly-only details on flag_metadata, so hooks (including OpenTelemetry) can read them.

ResolutionDetailsConverter maps variationIndex, inExperiment, ruleIndex, ruleId, prerequisiteKey, and bigSegmentsStatus from the evaluation reason. Keys are omitted when they do not apply (including inExperiment when false, and variationIndex for default values). bigSegmentsStatus is stringified.

The README documents the keys and a usage example. Specs cover each field and the omission cases.

Reviewed by Cursor Bugbot for commit deaf178. Bugbot is set up for automated code reviews on this repo. Configure here.

@kinyoklion kinyoklion self-assigned this Aug 19, 2026
@devin-ai-integration devin-ai-integration Bot added the devin-pr PRs created by Devin label Aug 19, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@kinyoklion
kinyoklion marked this pull request as ready for review August 20, 2026 21:57
@kinyoklion
kinyoklion requested a review from a team as a code owner August 20, 2026 21:57
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/ruby-flag-metadata branch from fff1c72 to 138b507 Compare August 21, 2026 21:42
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/ruby-flag-metadata branch from 138b507 to deaf178 Compare August 21, 2026 21:54
@kinyoklion
kinyoklion merged commit e6ef78a into main Aug 21, 2026
8 checks passed
@kinyoklion
kinyoklion deleted the devin/ruby-flag-metadata branch August 21, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PRs created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants