Add OCI Windows machine images - #429
Conversation
65c40f2 to
dd4f0b7
Compare
dd4f0b7 to
a6c00b9
Compare
ab190c7 to
fbed517
Compare
-->
✱ stlc build✅ go code · compare
✅ python code · compare
✅ typescript code · compare
Diagnostics: ❗ 0 new / 1 total error, 💡 0 new / 5 total note
Build metadata
This comment is auto-generated by stlc and is kept up to date as you push. |
fbed517 to
31b5a61
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 31b5a61. Configure here.

summary
windows-baseartifacts from launchablewindows-imageartifactstargeted tests
Long-running KVM and full CI suites were not run for this review pass.
Note
High Risk
Touches image pull/materialization, deletion of digest-backed artifacts, and instance boot/hypervisor config for a new guest OS. Disk rebase, firmware/TPM setup, and delete-dependency checks are security- and data-sensitive.
Overview
Adds Windows machine images as labeled OCI artifacts (
windows-basevs launchablewindows-image) instead of treating ordinary Windows containers as bootable.On pull, Hypeman parses
io.hypeman.machine-image.*labels, rejects path escapes and encrypted/external backing, converts bases (raw/qcow2/VHD/VHDX) to immutable sparse raw, and rebases qcow2 images onto a digest-pinned cache-owned base. Image metadata now storesMachine; deleting a base is blocked while a cached image still references it.windows/amd64is a valid platform; implicit host-platform creates no longer pick a cached Windows image.Instance create clones the image to a private qcow2, copies OVMF NVRAM, and sets up swtpm. Boot is UEFI + Secure Boot + TPM 2.0 with 8 GiB / 4 vCPU defaults (min 4 GiB / 2 vCPU). Overlay resize, Linux config disks, kernels, networking, volumes, devices, env/cmd, and snapshot/fork/standby/restore are rejected for this phase.
Reviewed by Cursor Bugbot for commit 0dc80f4. Bugbot is set up for automated code reviews on this repo. Configure here.