Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
inspectsubcommand currently raises an internal exception when feed autodiscovery returns no feeds, which is not friendly for CLI users.Description
inspect_urlraiseAutomatic::Errorwith a clear message whenFeedbag.findreturns an empty list by addingraise Automatic::Error, "no feed found at #{url}" if feeds.empty?.spec/lib/automatic/cli_spec.rbthat stubsFeedbag.findto return[]and asserts the command returnsEXIT_FAILURE, emits the expected error text, and produces no stdout.doc/VERSIONSto document the new behavior and bump file header update timestamps in the modified source and spec files.Testing
rspec spec/lib/automatic/cli_spec.rband the suite containing the newinspecttest passed successfully.Codex Task