fix(bigtable): Log warning on background task failure instead of exception - #18193
Draft
daniel-sanche wants to merge 4 commits into
Draft
fix(bigtable): Log warning on background task failure instead of exception#18193daniel-sanche wants to merge 4 commits into
daniel-sanche wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Bigtable client and query iterator to gracefully handle task creation failures during background channel refresh and instance registration by catching exceptions, logging warnings, and proceeding with the tasks disabled. The review feedback highlights that the newly added fallback unit tests should be updated to explicitly assert the expected call sequence and arguments of the mocked create_task helper, ensuring compliance with the repository's style guide on mock hygiene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bigtable data clients use background threads/coroutines to keep grpc channels warmed, and refresh them before expiration. These background tasks can fail due to resource exhaustion, or other issues.
This PR will log a warning and continue if there is an error during task set up, instead of rasing an exception
Also improves exception capture, which would sometimes state misleading information about the cause of the error.