feat(bigtable): Rerouted DirectRow.commit to use mutate_row - #18191
Draft
daniel-sanche wants to merge 3 commits into
Draft
feat(bigtable): Rerouted DirectRow.commit to use mutate_row#18191daniel-sanche wants to merge 3 commits into
daniel-sanche wants to merge 3 commits into
Conversation
**Changes Made:** - Use MutateRow instead of MutateRows for DirectRow.commit instead of Table.MutateRows - Added system test for DirectRow.commit because of the decoupling of DirectRow.commit and Table.MutateRows - Adjusted input error system test because of slight changes in error behavior - Adjusted unit tests for DirectRow.commit
daniel-sanche
changed the title
daniel-sanche
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the commit method in the Row class to use the direct mutate_row API call instead of mutate_rows. It updates error handling to catch GoogleAPICallError and map it to a Status object, while raising a ValueError if no mutations are present. System and unit tests are updated and added to verify these changes. A review comment points out that GoogleAPICallError does not have a details attribute, which would cause an AttributeError at runtime, and suggests using getattr as a safe fallback.
daniel-sanche
marked this pull request as draft
August 21, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating over @gkevinzheng PR from bigtable monorepo googleapis/python-bigtable#1276
Original description:
Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary