Skip to content

docs(sqlalchemy-bigquery): centralize CONTRIBUTING.rst pointer - #18157

Closed
chalmerlowe wants to merge 1 commit into
mainfrom
feat/sqlalchemy-bigquery-contributing
Closed

docs(sqlalchemy-bigquery): centralize CONTRIBUTING.rst pointer#18157
chalmerlowe wants to merge 1 commit into
mainfrom
feat/sqlalchemy-bigquery-contributing

Conversation

@chalmerlowe

@chalmerlowe chalmerlowe commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Problem

Each software package in this repository contains a contributing guide. Previously, these guides spelled out detailed installation steps, supported Python versions, and dependency rules locally, which caused unnecessary maintenance work whenever those details changed.

Solution

Updated the contributing guide for the sqlalchemy-bigquery package to point directly to the centralized setup files and Python configuration, removing duplicated and hardcoded instructions.

Notes for Reviewers

This change separates out the sqlalchemy-bigquery package update from the broader repository-wide contributing guide centralization PR.

Blocked by: #17642

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the CONTRIBUTING.rst file in the sqlalchemy-bigquery package by removing redundant, package-specific contributing instructions and replacing them with a reference to the centralized contributing guide at the root of the google-cloud-python monorepo. There are no review comments to address, and I have no additional feedback to provide.

@chalmerlowe chalmerlowe self-assigned this Aug 19, 2026
chalmerlowe added a commit that referenced this pull request Aug 20, 2026
### Problem
1. Each package has a `CONTRIBUTING.rst` file and each file contained
references to supported Python runtimes and specific dependency
versions, etc.
2. The references to supported runtimes and needed dependencies needed
to be updated every time we changed the install environment, which was
unnecessary toil.

### Solution
1. Package-level `CONTRIBUTING.rst` files in handwritten libraries
simply point to a centralized file in the repository root.
2. Removed all references from both the package-level mini-files and the
repository's centralized file that used to spell out which Python
runtime versions apply to this package. Instead we now point users to
the `noxfile.py`, `setup.py`, and `pyproject.toml` as sources of truth
for runtimes and other dependencies.

### Out of Scope/Future work
1. Update GAPIC templates to point at the central `CONTRIBUTING.rst`
file.
2. Failing packages that are being processed independently: 
   * #18041
   * #18142
   * #18157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant