docs(django-spanner, common-protos): centralize CONTRIBUTING.rst pointers - #18041
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces individual markdown contribution guides with package-specific RestructuredText (RST) files pointing to the centralized contributing guide at the repository root of the google-cloud-python monorepo. I have no feedback to provide as there are no review comments.
chalmerlowe
force-pushed
the
feat/centralize-contributing-deferred
branch
from
August 11, 2026 08:56
7dcb45c to
8189812
Compare
chalmerlowe
changed the title
chalmerlowe
marked this pull request as ready for review
August 19, 2026 13:48
chalmerlowe
added a commit
that referenced
this pull request
Aug 20, 2026
### Problem 1. Each package has a `CONTRIBUTING.rst` file and each file contained references to supported Python runtimes and specific dependency versions, etc. 2. The references to supported runtimes and needed dependencies needed to be updated every time we changed the install environment, which was unnecessary toil. ### Solution 1. Package-level `CONTRIBUTING.rst` files in handwritten libraries simply point to a centralized file in the repository root. 2. Removed all references from both the package-level mini-files and the repository's centralized file that used to spell out which Python runtime versions apply to this package. Instead we now point users to the `noxfile.py`, `setup.py`, and `pyproject.toml` as sources of truth for runtimes and other dependencies. ### Out of Scope/Future work 1. Update GAPIC templates to point at the central `CONTRIBUTING.rst` file. 2. Failing packages that are being processed independently: * #18041 * #18142 * #18157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR centralizes the contributing guidelines for
django-google-spannerandgoogleapis-common-protos, redirecting to the rootCONTRIBUTING.rst.These packages were separated from the main batch (see PR #17642) because they were failing
import-profilerchecks due to pre-existing environment/configuration issues, independent of this change.It appears that those issues have been resolved.
Blocked by PR #17642