Skip to content

chore(GkeConnectGateway): remove obsolete wildcard HTTP sample files - #9556

Open
sofisl wants to merge 1 commit into
mainfrom
feat/gkeconnectgateway
Open

chore(GkeConnectGateway): remove obsolete wildcard HTTP sample files#9556
sofisl wants to merge 1 commit into
mainfrom
feat/gkeconnectgateway

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete sample files for GkeConnectGateway that are no longer generated.

Testing Deletions

No core library classes were deleted in this PR, only orphaned sample files for GatewayServiceClient. The core GatewayServiceClient was deleted in a prior PR, but its corresponding samples were mistakenly left behind.

Test Script:

<?php
require 'vendor/autoload.php';
echo "Testing client existence...\n";
if (class_exists('Google\Cloud\GkeConnect\Gateway\V1beta1\Client\GatewayServiceClient')) {
    echo "ERROR: GatewayServiceClient V1beta1 still exists!\n";
    exit(1);
} else {
    echo "SUCCESS: GatewayServiceClient V1beta1 does not exist.\n";
}

Output:

Testing client existence...
SUCCESS: GatewayServiceClient V1beta1 does not exist.

BREAKING_CHANGE_REASON=When GatewayServiceClient in V1beta1 was deprecated and removed from google-cloud-php in PR #7943, OwlBot successfully deleted the core class files but failed to clean up the associated samples/V1beta1/GatewayServiceClient directory. Librarian's strict generation correctly removes these orphaned artifacts. There is no impact to the core client functionality.

For googleapis/librarian#7366

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 21:53
@snippet-bot

snippet-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant