Skip to content

chore(ConfidentialComputing): remove obsolete files - #9548

Open
sofisl wants to merge 1 commit into
mainfrom
feat/confidentialcomputing
Open

chore(ConfidentialComputing): remove obsolete files#9548
sofisl wants to merge 1 commit into
mainfrom
feat/confidentialcomputing

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete structural files for ConfidentialComputing that are no longer generated.

Testing Deletions

I attempted to load the deleted classes to prove they do not exist anymore.

Test Script:

<?php
require 'vendor/autoload.php';
echo "Testing deleted classes for ConfidentialComputing...\n";
$success = true;
if (class_exists('Google\Cloud\ConfidentialComputing\V1\VerifyAttestationRequest\AwsPrincipalTagsOptions') || interface_exists('Google\Cloud\ConfidentialComputing\V1\VerifyAttestationRequest\AwsPrincipalTagsOptions') || trait_exists('Google\Cloud\ConfidentialComputing\V1\VerifyAttestationRequest\AwsPrincipalTagsOptions')) {
    echo "ERROR: Google\Cloud\ConfidentialComputing\V1\VerifyAttestationRequest\AwsPrincipalTagsOptions still exists!\n";
    $success = false;
} else {
    echo "SUCCESS: Google\Cloud\ConfidentialComputing\V1\VerifyAttestationRequest\AwsPrincipalTagsOptions does not exist.\n";
}
if (!$success) exit(1);

Output:

Testing deleted classes for ConfidentialComputing...
SUCCESS: Google\Cloud\ConfidentialComputing\V1\VerifyAttestationRequest\AwsPrincipalTagsOptions does not exist.

BREAKING_CHANGE_REASON=In googleapis PR #8549 (September 2025), the message AwsPrincipalTagsOptions was moved to a top-level message. OwlBot correctly generated the new file but failed to delete the obsolete nested VerifyAttestationRequest\AwsPrincipalTagsOptions.php file.

For googleapis/librarian#7366

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 19:50
@sofisl
sofisl force-pushed the feat/confidentialcomputing branch from 0c7226b to 0ea481c Compare August 21, 2026 19:51
@sofisl
sofisl force-pushed the feat/confidentialcomputing branch from 0ea481c to 10e942f Compare August 21, 2026 19:52
@sofisl
sofisl marked this pull request as draft August 21, 2026 19:59
@sofisl
sofisl marked this pull request as ready for review August 21, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant