Skip to content

fix(rails): set dummy rails app before calling initializers - #3055

Merged
sl0thentr0py merged 1 commit into
masterfrom
fix/tests-set-dummy-rails-app-class-early
Aug 17, 2026
Merged

fix(rails): set dummy rails app before calling initializers#3055
sl0thentr0py merged 1 commit into
masterfrom
fix/tests-set-dummy-rails-app-class-early

Conversation

@solnic

@solnic solnic commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

I noticed a flaky failure in the new DC specs and it turned out to be an issue with our Rails dummy app init process - this should fix it.

With the fix this and most likely other specs will not be flaky:

Failures:

  1) Sentry::Rails data collection adds Rails filter parameters to URL query parameter data collection
     Failure/Error:
       expect(Sentry.configuration.data_collection.url_query_params.terms).to include(
         "password",
         "custom_secret"
       )

       expected [] to include "password" and "custom_secret"
     # ./spec/sentry/rails_spec.rb:117:in `block (3 levels) in <top (required)>'

Finished in 37.38 seconds (files took 1.18 seconds to load)
290 examples, 1 failure, 34 pending

Failed examples:

rspec ./spec/sentry/rails_spec.rb:116 # Sentry::Rails data collection adds Rails filter parameters to URL query parameter data collection

Randomized with seed 19348

#skip-changelog

@solnic
solnic marked this pull request as ready for review August 17, 2026 10:05
@solnic
solnic requested a review from sl0thentr0py August 17, 2026 10:06
@sl0thentr0py
sl0thentr0py merged commit 040fb0d into master Aug 17, 2026
157 of 158 checks passed
@sl0thentr0py
sl0thentr0py deleted the fix/tests-set-dummy-rails-app-class-early branch August 17, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants