Make wasm-tools mock in build metadata test cross-platform - #1885
Merged
Conversation
TestReadExistingPackageInfo mocked wasm-tools with a bash script, which exec.Command cannot run on Windows (no shebang support, no POSIX exec bits). Replace it with a small Go program compiled on the fly that emits the scenario JSON via an env var, so the test passes on windows-latest CI.
anthony-gomez-fastly
added
the
Skip-Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
TestReadExistingPackageInfo mocked wasm-tools with a bash script, which exec.Command cannot run on Windows (no shebang support, no POSIX exec bits). Replace it with a small Go program compiled on the fly that emits the scenario JSON via an env var, so the test passes on windows-latest CI.
All Submissions:
New Feature Submissions: