Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/infrastructure/cluster.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright (c) 2019-2025 Red Hat, Inc.
// Copyright (c) 2019-2026 Red Hat, Inc.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down
32 changes: 32 additions & 0 deletions webhook/workspace/annotations.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
//
// Copyright (c) 2019-2026 Red Hat, Inc.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

package workspace

import (
"fmt"

"github.com/devfile/devworkspace-operator/pkg/infrastructure"
)

func getWebhookAnnotations(namespace string) map[string]string {
annotations := map[string]string{}
Comment thread
tolusha marked this conversation as resolved.
if infrastructure.IsOpenShift() {
annotations["service.beta.openshift.io/inject-cabundle"] = "true"
} else {
annotations["cert-manager.io/inject-ca-from"] = fmt.Sprintf("%s/devworkspace-controller-serving-cert", namespace)
}
return annotations
}
39 changes: 39 additions & 0 deletions webhook/workspace/annotations_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
//
// Copyright (c) 2019-2026 Red Hat, Inc.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

package workspace

import (
"testing"

"github.com/devfile/devworkspace-operator/pkg/infrastructure"
"github.com/stretchr/testify/assert"
)

func TestGetWebhookAnnotationsWithOpenShift(t *testing.T) {
infrastructure.InitializeForTesting(infrastructure.OpenShiftv4)
annotations := getWebhookAnnotations("test-namespace")
assert.Equal(t, map[string]string{
"service.beta.openshift.io/inject-cabundle": "true",
}, annotations)
}

func TestGetWebhookAnnotationsWithKubernetes(t *testing.T) {
infrastructure.InitializeForTesting(infrastructure.Kubernetes)
annotations := getWebhookAnnotations("test-namespace")
assert.Equal(t, map[string]string{
"cert-manager.io/inject-ca-from": "test-namespace/devworkspace-controller-serving-cert",
}, annotations)
}
7 changes: 4 additions & 3 deletions webhook/workspace/mutating_cfg.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright (c) 2019-2025 Red Hat, Inc.
// Copyright (c) 2019-2026 Red Hat, Inc.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down Expand Up @@ -153,8 +153,9 @@ func BuildMutateWebhookCfg(namespace string) *admregv1.MutatingWebhookConfigurat

return &admregv1.MutatingWebhookConfiguration{
ObjectMeta: metav1.ObjectMeta{
Name: MutateWebhookCfgName,
Labels: server.WebhookServerAppLabels(),
Name: MutateWebhookCfgName,
Labels: server.WebhookServerAppLabels(),
Annotations: getWebhookAnnotations(namespace),
Comment thread
tolusha marked this conversation as resolved.
},
Webhooks: []admregv1.MutatingWebhook{
workspaceMutateWebhook,
Expand Down
7 changes: 4 additions & 3 deletions webhook/workspace/validating_cfg.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright (c) 2019-2025 Red Hat, Inc.
// Copyright (c) 2019-2026 Red Hat, Inc.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down Expand Up @@ -34,8 +34,9 @@ func buildValidatingWebhookCfg(namespace string) *admregv1.ValidatingWebhookConf
sideEffectsNone := admregv1.SideEffectClassNone
return &admregv1.ValidatingWebhookConfiguration{
ObjectMeta: metav1.ObjectMeta{
Name: ValidateWebhookCfgName,
Labels: server.WebhookServerAppLabels(),
Name: ValidateWebhookCfgName,
Labels: server.WebhookServerAppLabels(),
Annotations: getWebhookAnnotations(namespace),
},
Webhooks: []admregv1.ValidatingWebhook{
{
Expand Down