Skip to content

Drop stale/unreachable code and gCling. NFC - #23

Merged
aaronj0 merged 3 commits into
mainfrom
interop-dead-code-cleanup
Aug 18, 2026
Merged

Drop stale/unreachable code and gCling. NFC#23
aaronj0 merged 3 commits into
mainfrom
interop-dead-code-cleanup

Conversation

@aaronj0

@aaronj0 aaronj0 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Drops commented-out blocks, unused globals, py2-only paths, unused/hardcoded build-tree include paths and the emulated cling::runtime::gCling void pointer. NFC

@github-actions

Copy link
Copy Markdown

Test Results

Configuration Result
macos-26-intel-llvm21-py3.14-cxx20 = 437 passed, 44 skipped, 85 xfailed, 32 xpassed, 100 warnings in 108.42s (0:01:48) =
macos-26-llvm21-py3.14-cxx20 = 438 passed, 37 skipped, 93 xfailed, 30 xpassed, 100 warnings in 71.43s (0:01:11) =
ubuntu-24.04-llvm21-py3.14-cxx20-vg ====== 553 passed, 25 skipped, 18 xfailed, 2 xpassed in 95.62s (0:01:35) =======
ubuntu-24.04-llvm22-py3.14-cxx20 ====== 553 passed, 25 skipped, 19 xfailed, 1 xpassed in 92.83s (0:01:32) =======
ubuntu-24.04-llvm22-py3.14-cxx20-cling ====== 543 passed, 25 skipped, 27 xfailed, 3 xpassed in 107.41s (0:01:47) ======
ubuntu-24.04-llvm22-py3.14-cxx23 ====== 574 passed, 3 skipped, 20 xfailed, 1 xpassed in 106.39s (0:01:46) =======

@aaronj0
aaronj0 requested a review from guitargeek August 18, 2026 09:56

@Vipul-Cariappa Vipul-Cariappa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronj0
aaronj0 merged commit 5a33027 into main Aug 18, 2026
7 checks passed
@aaronj0
aaronj0 deleted the interop-dead-code-cleanup branch August 18, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants