clean code - #145
Open
lgustavopuga wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to be a broad “cleanup” that removes nearly all exercise solution implementations across the repository, leaving many scripts empty or reduced to header comments, plus a minor whitespace-only change in the README.
Changes:
- Emptied or stubbed out dozens of exercise solution scripts across chapters 1–8.
- Removed previously runnable examples (functions, control flow, loops, classes, modules) from their respective files.
- Added an extra blank line in
README.mdwithout updating the README’s “solutions” positioning.
Reviewed changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a blank line; still describes repo as containing solutions while many linked files are now empty/stubs |
| 8-modules/42_forty_two.py | Removed module usage; file now header-only/stub |
| 8-modules/41_main.py | Removed countdown logic; file now header-only/stub |
| 8-modules/41_bday_messages.py | Removed messages/random selection; file now header-only/stub |
| 8-modules/40_solar_system.py | Removed planet selection/area computation; file now header-only/stub |
| 8-modules/39_slot_machine_2.py | Removed slot machine loop/gameplay; file now header-only/stub |
| 8-modules/39_slot_machine_1.py | Removed slot machine one-shot logic; file now header-only/stub |
| 7-classes-objects/38_pokedex_2.py | Removed class + object usage; file now header-only/stub |
| 7-classes-objects/38_pokedex_1.py | Removed class + object usage; file now header-only/stub |
| 7-classes-objects/37_bank_accounts.py | Removed class + operations; file now header-only/stub |
| 7-classes-objects/36_favorite_cities.py | Removed class + instances; file now header-only/stub |
| 7-classes-objects/35_bobs_burgers.py | Removed class usage/instances; file now header-only/stub |
| 7-classes-objects/34_restaurants.py | Removed class definition; file now header-only/stub |
| 6-functions/33_drive_thru.py | Removed menu + functions; file now header-only/stub |
| 6-functions/32_stonks.py | Removed price helpers and outputs; file now header-only/stub |
| 6-functions/31_calculator.py | Removed calculator implementation and outputs; file now header-only/stub |
| 6-functions/30_rocket.py | Removed conversion function and call; file now header-only/stub |
| 6-functions/29_fortune_cookie_2.py | Removed fortune logic; file now header-only/stub |
| 6-functions/29_fortune_cookie_1.py | Removed fortune logic; file now header-only/stub |
| 6-functions/28_dry.py | Removed example calls/comments; file now header-only/stub |
| 5-lists/27_bucket_list.py | Removed list + loop; file now header-only/stub |
| 5-lists/26_mixtape.py | Removed playlist + loop; file now header-only/stub |
| 5-lists/25_reading_list.py | Removed list ops; file now header-only/stub |
| 5-lists/24_inventory.py | Removed min/max example; file now header-only/stub |
| 5-lists/23_todo.py | Removed list indexing examples; file now header-only/stub |
| 5-lists/22_grocery.py | Removed list + print; file now header-only/stub |
| 4-loops/21_fizz_buzz.py | Removed fizzbuzz loop; file now header-only/stub |
| 4-loops/20_99_bottles.py | Removed countdown loop; file now header-only/stub |
| 4-loops/19_detention.py | Removed loop; file now header-only/stub |
| 4-loops/18_guess_number.py | Removed guessing loop; file now header-only/stub |
| 4-loops/17_enter_pin.py | Removed PIN loop; file now header-only/stub |
| 3-control-flow/16_sorting_hat_2.py | Removed interactive quiz logic; file now header-only/stub |
| 3-control-flow/16_sorting_hat_1.py | Removed interactive quiz logic; file now header-only/stub |
| 3-control-flow/15_the_cyclone_2.py | Removed conditional logic; file now header-only/stub |
| 3-control-flow/15_the_cyclone_1.py | Removed conditional logic; file now header-only/stub |
| 3-control-flow/14_magic_8_ball.py | Removed RNG + branching; file now header-only/stub |
| 3-control-flow/13_ph_levels.py | Removed input + branching; file now header-only/stub |
| 3-control-flow/12_grades.py | Removed pass/fail example; file now header-only/stub |
| 3-control-flow/11_coin_flip.py | Removed RNG coin flip; file now header-only/stub |
| 2-variables/10_currency.py | Removed inputs + conversion; file now header-only/stub |
| 2-variables/09_quadratic.py | Removed quadratic computation; file now header-only/stub |
| 2-variables/09_hypotenuse.py | Removed hypotenuse computation; file now header-only/stub |
| 2-variables/08_bmi.py | Removed BMI computation; file now header-only/stub |
| 2-variables/07_temperature.py | Removed temperature conversion; file now header-only/stub |
| 1-hello-world/05_letter.py | Removed ASCII-letter output; file now header-only/stub |
| 1-hello-world/05_letter_2.py | Removed ASCII-letter output; file now header-only/stub |
| 1-hello-world/04_initials.py | Removed initials output; file now comment-only/stub |
| 1-hello-world/03_pattern.py | Emptied file (pattern output removed) |
| 1-hello-world/02_hello_world.py | Emptied file (hello world output removed) |
| 1-hello-world/01_setting_up.py | Removed example output; file now comment-only/stub |
Suppressed comments (2)
1-hello-world/01_setting_up.py:2
- This exercise script is now effectively empty (only a comment), so it no longer demonstrates the intended behavior. If this repo is meant to contain solutions (per README), the removed code should be restored rather than leaving a no-op file.
# Write code below 💖
6-functions/31_calculator.py:4
- This solution file has been reduced to just header comments, so running it no longer demonstrates the calculator functions. If the intent is to keep solutions runnable, the removed implementation should be restored (or the file removed from the README/chapter lists).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| </div> | ||
| <br> | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.