SP-2221: Omit --layers instead of defaulting it to SCHEMA - #419
Merged
Kastriot Salihu (ksalihu) merged 1 commit intoAug 20, 2026
Merged
Conversation
config package validate defaulted --layers to ["SCHEMA"], so the out-of-the-box run reported schema problems only and said nothing about business rules, package settings or the semantic model. A user comparing the output against the Studio problems panel saw a much shorter list with no indication that four layers had not run. Omitting the option now sends no layers at all, which the validate API reads as every layer available for the team. An explicit list still narrows the run, and an empty one is dropped rather than sent, since the API rejects it. Includes-AI-Code: true
|
Kastriot Salihu (ksalihu)
marked this pull request as ready for review
August 19, 2026 13:40
Zgjim Haziri (ZgjimHaziri)
approved these changes
Aug 19, 2026
Kastriot Salihu (ksalihu)
deleted the
ksalihu/SP-2221-validate-default-layers
branch
August 20, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
config package validate(and the deprecatedconfig validate) declared--layerswith a Commander default of["SCHEMA"]. So the plain command reported schema problems only and said nothing about business rules, package settings or the semantic model, while the Studio problems panel reports five layers for the same package. Nothing in the output indicated four layers had not run, so a short report looked like a clean package.The docs told users to pass all five explicitly, which only works until a sixth layer ships.
What changed
--layersdeclarations drop the["SCHEMA"]default. The help text now says the option narrows the run rather than that it defaults to SCHEMA.PackageValidationService.validatePackageomitslayersfrom the request body when nothing was passed, and drops an empty array rather than sending one the API rejects.PackageValidationRequest.layersis optional.--layersis rejected.An explicit
--layers SCHEMA BUSINESSstill behaves exactly as before.Testing
npx jest tests/commands/configuration-management/config-validate.spec.ts— 10 passed. Two new cases cover the omitted option producing{}and an empty array being dropped whilenodeKeyssurvives.tsc --noEmitclean;tslint -p .reports only pre-existing errors in files this PR does not touch.Ticket: SP-2221
Made with Cursor