Skip to content

fix(vibenet): preserve sign when formatting token amounts - #71

Open
burak33bb wants to merge 1 commit into
base:mainfrom
burak33bb:codex/fix-vibenet-negative-format-amount
Open

fix(vibenet): preserve sign when formatting token amounts#71
burak33bb wants to merge 1 commit into
base:mainfrom
burak33bb:codex/fix-vibenet-negative-format-amount

Conversation

@burak33bb

@burak33bb burak33bb commented Aug 16, 2026

Copy link
Copy Markdown

Summary

  • Fix negative fractional output in app/vibenet/library/format.ts's string-based formatAmount helper.
  • Add focused regression tests for positive, negative, and invalid amount inputs.

Why

This is separate from #68, which updates fmtTokenAmount in app/vibenet/library/explorer.ts and formatBigInt in app/tips/library/format.ts; this PR fixes the Vibenet faucet/status formatter used by faucetTokens.ts.

Testing

  • npx vitest run app/vibenet/library/format.test.ts
  • npm run typecheck
  • npm run lint
  • git diff --check

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

@burak33bb is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@burak33bb
burak33bb marked this pull request as ready for review August 16, 2026 23:38
@burak33bb
burak33bb force-pushed the codex/fix-vibenet-negative-format-amount branch from 6316c71 to 99ecfd7 Compare August 17, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants