tools/nxstyle: indent code against its enclosing brace, not modulo 4 - #19933
Draft
raiden00pl wants to merge 3 commits into
Draft
tools/nxstyle: indent code against its enclosing brace, not modulo 4#19933raiden00pl wants to merge 3 commits into
raiden00pl wants to merge 3 commits into
Conversation
Braces were only tested against a multiple of the indentation unit, so one at the wrong level still passed. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
The check added by the preceding commit reports ten braces in nxstyle.c that do not line up with the brace they close, and a comment that does not share the column of the run it belongs to. Bring the whole file into line with the standard, so that the checks added by the commits that follow are not introduced against a file that breaks them. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
A residue modulo four expresses neither the indentation unit nor the alignment of case logic, and all of it was disabled from the first switch to the end of the enclosing function. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
github-actions
Bot
added
Area: Tooling
Size: XL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/nxstyle: indent code against its enclosing brace, not modulo 4
Impact
nuttx standard compatibility
Testing
correctly detect wrong alignment like below: