graphics/nxterm: add some missing features - #19932
Merged
xiaoxiang781216 merged 2 commits intoAug 23, 2026
Merged
Conversation
Handle carriage return, cursor-left/right, and erase-to-end-of-line sequences required by readline. Restore glyphs hidden by the cursor so edited text redraws correctly. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: OpenAI Codex:gpt-5
Recognize variable-length ANSI SGR sequences and consume them without changing attributes so unsupported color controls are not rendered as terminal text. Signed-off-by: raiden00pl <raiden00@railab.me>
raiden00pl
requested review from
gustavonihei,
jerpelea,
pkarashchenko and
xiaoxiang781216
as code owners
August 22, 2026 06:04
github-actions
Bot
added
Size: M
|
xiaoxiang781216
approved these changes
Aug 22, 2026
simbit18
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
improvements for nxterm
Testing
Intel NUC 12 with python interactive interpreter on display: