Skip to content

allow creating ldap accounts after linking accounts to the same the d… - #13945

Open
DaanHoogland wants to merge 1 commit into
4.20from
ghi8732-ldap-createaccount-group-scope
Open

allow creating ldap accounts after linking accounts to the same the d…#13945
DaanHoogland wants to merge 1 commit into
4.20from
ghi8732-ldap-createaccount-group-scope

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

…omain

Description

This PR...

Fixes: #8732

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.34%. Comparing base (6136ac9) to head (cbc13c4).

Files with missing lines Patch % Lines
...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13945      +/-   ##
============================================
+ Coverage     16.32%   16.34%   +0.02%     
- Complexity    13556    13577      +21     
============================================
  Files          5669     5669              
  Lines        501399   501403       +4     
  Branches      60902    60903       +1     
============================================
+ Hits          81847    81978     +131     
+ Misses       410390   410241     -149     
- Partials       9162     9184      +22     
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.21% <92.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create another ldap Account if another account is linked to ldap group in the same domain

1 participant