Fix type parameter in listBackupServiceJobs API - #13940
Open
JoaoJandre wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@winterhazel @weizhouapache I do not think this is a huge issue, but since the fix is simple, if there is a chance to add it to the next RC, it could be nice :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13940 +/- ##
============================================
- Coverage 19.65% 19.65% -0.01%
+ Complexity 19803 19801 -2
============================================
Files 6368 6368
Lines 574935 574935
Branches 70358 70358
============================================
- Hits 113026 113011 -15
- Misses 449632 449649 +17
+ Partials 12277 12275 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The parameter
typeof the listBackupServiceJobs is not required. However, the current implementation fails with a NPE if thetypeis not informed.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I called the API informing the
typeparameter and it was OK. I then called the API without informing it and it was OK as well.