Add externalloadbalanceripaddress field to KubernetesCluster struct - #163
Open
sureshanaparti wants to merge 1 commit into
Open
Add externalloadbalanceripaddress field to KubernetesCluster struct#163sureshanaparti wants to merge 1 commit into
sureshanaparti wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CloudStack Go client’s Kubernetes cluster model to expose the external load balancer IP address returned by the API, which is needed for HA Kubernetes cluster workflows on Shared networks.
Changes:
- Add
externalloadbalanceripaddressto theKubernetesClusterresponse model used bylistKubernetesClusters(and helper getters that rely on it).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1851
to
+1853
| Etcdips map[string]string `json:"etcdips"` | ||
| Externalloadbalanceripaddress string `json:"externalloadbalanceripaddress"` | ||
| Etcdnodes int64 `json:"etcdnodes"` |
… KubernetesCluster struct Exposes two fields for Kubernetes cluster configuration: - externalloadbalanceripaddress: external load balancer IP for HA clusters on Shared networks - enablecsi: enable CloudStack CSI for cluster storage management (alias for csienabled) The enablecsi field is added for consistency with the API parameter naming.
sureshanaparti
force-pushed
the
feature/issue-275-external-load-balancer-csi
branch
from
August 17, 2026 17:11
f453e4b to
11b9d0c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
cloudstack/KubernetesService.go:1848
KubernetesClusternow has two exported fields (CsienabledandEnablecsi) with the same JSON tagcsienabled. In Go'sencoding/json, duplicate tags on the same struct level make field selection ambiguous and can result in the value being dropped during unmarshal, so clients may always see the zero value. Remove the duplicate field (or give it a distinct tag if the API really returns two different properties).
Csienabled bool `json:"csienabled"`
Description string `json:"description"`
Enablecsi bool `json:"csienabled"`
Domain string `json:"domain"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the external load balancer IP address parameter for Kubernetes clusters, enabling HA cluster deployments on Shared networks via the API client.